[ 
https://issues.apache.org/jira/browse/BEAM-10341?focusedWorklogId=458437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458437
 ]

ASF GitHub Bot logged work on BEAM-10341:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/20 03:32
            Start Date: 14/Jul/20 03:32
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r454077833



##########
File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##########
@@ -99,6 +99,24 @@
    */
   public abstract void checkDone() throws IllegalStateException;
 
+  public enum RestrictionBoundness {
+    IS_BOUNDED,
+    IS_UNBOUNDED
+  }
+
+  /**
+   * Return the boundedness of current tracking restriction. If the current 
restriction produces
+   * finite output, it should return {@link RestrictionBoundness#IS_BOUNDED}. 
Otherwise, it should
+   * return {@link RestrictionBoundness#IS_UNBOUNDED}.
+   *
+   * <p>The API is called by the system when the pipeline starts to drain and 
there is no
+   * implementation of {@link DoFn.TruncateRestriction}. Based on the 
boundness of the restriction,
+   * the system will give the default behavior of truncating restrictions.
+   *
+   * <p>The API is required to be implemented.
+   */

Review comment:
       Created JIRA https://issues.apache.org/jira/browse/BEAM-10480 for 
tracking this cleanup.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 458437)
    Time Spent: 5.5h  (was: 5h 20m)

> Support drain in SDF
> --------------------
>
>                 Key: BEAM-10341
>                 URL: https://issues.apache.org/jira/browse/BEAM-10341
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-harness, sdk-py-harness
>            Reporter: Boyuan Zhang
>            Priority: P2
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to