[
https://issues.apache.org/jira/browse/BEAM-10341?focusedWorklogId=454496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-454496
]
ASF GitHub Bot logged work on BEAM-10341:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/20 03:49
Start Date: 04/Jul/20 03:49
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r449735426
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1079,6 +1079,13 @@ def construct_bundle_application(self,
):
# type: (...) -> beam_fn_api_pb2.BundleApplication
transform_id, main_input_tag, main_input_coder, outputs = op.input_info
+ # The main_input_coder should be the main_input_coder of
+ # SdfTruncateSizedRestrictions if SdfProcessSizedElements is following
+ # SdfTruncateSizedRestrictions.
+ if (isinstance(op, operations.SdfProcessSizedElements) and
Review comment:
The problem here is the restriction coder. At least for `FnApiRunner`,
when a `PCollection` crosses the wire, it seems like any non-standard coder
will be length-prefixed. Here, the input coder of `SdfTruncateSizedRestrictions
` is length-prefixed, but `SdfProcessSizedElements ` is not. On the
`FnApiRunner` side, it decodes the element-restriction pair with the
length-prefixed coder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 454496)
Time Spent: 4h 50m (was: 4h 40m)
> Support drain in SDF
> --------------------
>
> Key: BEAM-10341
> URL: https://issues.apache.org/jira/browse/BEAM-10341
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
