[
https://issues.apache.org/jira/browse/BEAM-10572?focusedWorklogId=463192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463192
]
ASF GitHub Bot logged work on BEAM-10572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/20 02:32
Start Date: 25/Jul/20 02:32
Worklog Time Spent: 10m
Work Description: jayendra13 commented on a change in pull request #12366:
URL: https://github.com/apache/beam/pull/12366#discussion_r460353530
##########
File path:
sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java
##########
@@ -66,12 +66,15 @@
});
}
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(0)
public String dialectName;
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(1)
public Class<? extends QueryPlanner> queryPlanner;
+ @SuppressWarnings("nullness")
Review comment:
I got this after enabling the checkerframework
```
/Users/jayendrap/lab/beam/sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java:100:
error: [argument.type.incompatible] incompatible types in argument.
.setPlannerName(queryPlanner.getCanonicalName());
^
found : @Initialized @Nullable String
required: @Initialized @NonNull String
```
I am assuming that it is thrown as `queryPlanner` is uninitialized so
compiler is inferring that `queryPlanner.getCanonicalName()` would give `null`
and hence I suppressed that. Am I correct here, or I can't understand any other
reason for this nullness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463192)
Time Spent: 1h (was: 50m)
> Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog
> -----------------------------------------------------------------------
>
> Key: BEAM-10572
> URL: https://issues.apache.org/jira/browse/BEAM-10572
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Jayendra
> Assignee: Jayendra
> Priority: P2
> Labels: starter
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
