[
https://issues.apache.org/jira/browse/BEAM-10572?focusedWorklogId=463196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463196
]
ASF GitHub Bot logged work on BEAM-10572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/20 02:58
Start Date: 25/Jul/20 02:58
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#12366:
URL: https://github.com/apache/beam/pull/12366#discussion_r460355720
##########
File path:
sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java
##########
@@ -66,12 +66,15 @@
});
}
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(0)
public String dialectName;
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(1)
public Class<? extends QueryPlanner> queryPlanner;
+ @SuppressWarnings("nullness")
Review comment:
The checkerframework nullness analysis is not a heuristic warning
framework like spotbugs/findbugs. It is a new and improved type system, so the
idea is to always satisfy it by the right types everywhere.
In this case, the [javadoc for
Class#getCanonicalName](https://github.com/typetools/jdk/blob/af987068c65767e101a3c58919cbae15ad08218b/src/java.base/share/classes/java/lang/Class.java#L1648)
says "the canonical name of the class if it exists, otherwise null". So the
checkerframework team has put a `@Nullable` annotation on the method. I
actually did not realize this method was nullable. That is pretty annoying. So
we might want to switch to just `getName` sometimes or otherwise use
`MoreObjects.firstNonNull` to give a default string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463196)
Time Spent: 1h 20m (was: 1h 10m)
> Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog
> -----------------------------------------------------------------------
>
> Key: BEAM-10572
> URL: https://issues.apache.org/jira/browse/BEAM-10572
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Jayendra
> Assignee: Jayendra
> Priority: P2
> Labels: starter
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
