[
https://issues.apache.org/jira/browse/BEAM-10572?focusedWorklogId=463204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463204
]
ASF GitHub Bot logged work on BEAM-10572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/20 03:17
Start Date: 25/Jul/20 03:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#12366:
URL: https://github.com/apache/beam/pull/12366#discussion_r460357318
##########
File path:
sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java
##########
@@ -66,12 +66,15 @@
});
}
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(0)
public String dialectName;
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(1)
public Class<? extends QueryPlanner> queryPlanner;
+ @SuppressWarnings("nullness")
Review comment:
Maybe... in this case I realize that the string is probably used to
create a planner by reflection. I don't know if that will work. If it does,
then that is great. If it does not work, then you'll want to check for null and
throw an exception. I've created a new Beam module to make this easy:
`org.apache.beam.sdk.utils.Preconditions.checkArgumentNotNull` returns a
non-nullable value after checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463204)
Time Spent: 1h 50m (was: 1h 40m)
> Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog
> -----------------------------------------------------------------------
>
> Key: BEAM-10572
> URL: https://issues.apache.org/jira/browse/BEAM-10572
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Jayendra
> Assignee: Jayendra
> Priority: P2
> Labels: starter
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
