[
https://issues.apache.org/jira/browse/BEAM-10900?focusedWorklogId=484683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484683
]
ASF GitHub Bot logged work on BEAM-10900:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/20 18:02
Start Date: 15/Sep/20 18:02
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #12851:
URL: https://github.com/apache/beam/pull/12851#issuecomment-692881256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=h1) Report
> Merging
[#12851](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/803efdd931699c24e60350e5ccf6e54482f5916f?el=desc)
will **decrease** coverage by `0.10%`.
> The diff coverage is `87.12%`.
[](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12851 +/- ##
==========================================
- Coverage 82.38% 82.27% -0.11%
==========================================
Files 451 451
Lines 53775 53730 -45
==========================================
- Hits 44303 44207 -96
- Misses 9472 9523 +51
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5)
| `74.32% <33.33%> (-0.85%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
| `92.14% <50.00%> (-0.02%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
| `84.70% <57.14%> (ø)` | |
|
[sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5)
| `96.83% <83.33%> (-0.93%)` | :arrow_down: |
|
[sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=)
| `87.65% <83.33%> (-0.35%)` | :arrow_down: |
|
[sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=)
| `93.20% <86.66%> (-3.41%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==)
| `90.47% <88.00%> (+3.08%)` | :arrow_up: |
|
[sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==)
| `94.36% <90.90%> (-0.64%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `90.48% <100.00%> (+0.07%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/gcp/pubsub.py](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3B1YnN1Yi5weQ==)
| `93.58% <100.00%> (+1.27%)` | :arrow_up: |
| ... and [31
more](https://codecov.io/gh/apache/beam/pull/12851/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=footer). Last
update
[63f54fd...4f71b9b](https://codecov.io/gh/apache/beam/pull/12851?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484683)
Time Spent: 40m (was: 0.5h)
> stats.ApproximateUniqueCombineFn should handle numpy array
> ----------------------------------------------------------
>
> Key: BEAM-10900
> URL: https://issues.apache.org/jira/browse/BEAM-10900
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Monica Song
> Assignee: Monica Song
> Priority: P1
> Time Spent: 40m
> Remaining Estimate: 0h
>
> stats.ApproximateUniqueCombineFn uses DeterministicFastPrimitivesCoder to
> encode input data. DeterministicFastPrimitivesCoder only accepts python data
> types and iterables, so numpy data types throw an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
