[
https://issues.apache.org/jira/browse/BEAM-10900?focusedWorklogId=484694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484694
]
ASF GitHub Bot logged work on BEAM-10900:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/20 18:07
Start Date: 15/Sep/20 18:07
Worklog Time Spent: 10m
Work Description: monicadsong commented on a change in pull request
#12851:
URL: https://github.com/apache/beam/pull/12851#discussion_r488863704
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -89,6 +90,12 @@ def setUp(self):
None,
0.1,
'assert:global_by_error_with_large_population'),
+ (
+ 'numpy_input_data',
+ np.array(range(10)),
Review comment:
No. For numpy input I am assuming that for
ApproxUniqueCombineFn.add_input(self, accumulator, element), element is a numpy
scalar or numpy array with 1 element.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484694)
Time Spent: 1h 20m (was: 1h 10m)
> stats.ApproximateUniqueCombineFn should handle numpy array
> ----------------------------------------------------------
>
> Key: BEAM-10900
> URL: https://issues.apache.org/jira/browse/BEAM-10900
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Monica Song
> Assignee: Monica Song
> Priority: P1
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> stats.ApproximateUniqueCombineFn uses DeterministicFastPrimitivesCoder to
> encode input data. DeterministicFastPrimitivesCoder only accepts python data
> types and iterables, so numpy data types throw an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
