[
https://issues.apache.org/jira/browse/BEAM-10900?focusedWorklogId=484817&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484817
]
ASF GitHub Bot logged work on BEAM-10900:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/20 23:30
Start Date: 15/Sep/20 23:30
Worklog Time Spent: 10m
Work Description: monicadsong commented on a change in pull request
#12851:
URL: https://github.com/apache/beam/pull/12851#discussion_r489074298
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -89,6 +90,12 @@ def setUp(self):
None,
0.1,
'assert:global_by_error_with_large_population'),
+ (
+ 'numpy_input_data',
+ np.array(range(10)),
Review comment:
Ah sorry, just saw this. I didn't like the assumption I made about the
type of elements in the PCollection either, and the use case you mention is
definitely unsupported with this draft edit but would not alert the user if
they made that mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484817)
Time Spent: 2h (was: 1h 50m)
> stats.ApproximateUniqueCombineFn should handle numpy array
> ----------------------------------------------------------
>
> Key: BEAM-10900
> URL: https://issues.apache.org/jira/browse/BEAM-10900
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Monica Song
> Assignee: Monica Song
> Priority: P1
> Time Spent: 2h
> Remaining Estimate: 0h
>
> stats.ApproximateUniqueCombineFn uses DeterministicFastPrimitivesCoder to
> encode input data. DeterministicFastPrimitivesCoder only accepts python data
> types and iterables, so numpy data types throw an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
