[
https://issues.apache.org/jira/browse/BEAM-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205007#comment-17205007
]
Brian Hulette commented on BEAM-10986:
--------------------------------------
Looks like you're right, it builds a zip and script(s), according to [gradle
docs|https://docs.gradle.org/current/userguide/application_plugin.html]:
{quote}
The Application plugin facilitates creating an executable JVM application. It
makes it easy to start the application locally during development, and to
package the application as a TAR and/or ZIP including operating system specific
start scripts.
{quote}
I'm not sure why we're using both shadow and application here, maybe we're
relying on application to add the Main-Class attribute in the shaded jar? For
the SQL expansion service I did this in the
[shadowClosure|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/expansion-service/build.gradle#L26]
Maybe [~robertwb] can comment since application has been there since
io/expansion-service was added in
https://github.com/apache/beam/commit/cf3ce65ac21603f961d95d96e82ec49590f948d7
> :build task doesn't build shaded jar with shadow >5.0.0
> -------------------------------------------------------
>
> Key: BEAM-10986
> URL: https://issues.apache.org/jira/browse/BEAM-10986
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P0
> Fix For: 2.25.0
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Not 100% sure but I believe this will prevent us from releasing shaded jars.
> See
> [https://lists.apache.org/thread.html/r12c785c2b01017329204ad816740e80b70c19c5f2bb1ea01535a987d%40%3Cdev.beam.apache.org%3E]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
