[ 
https://issues.apache.org/jira/browse/BEAM-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205755#comment-17205755
 ] 

Brian Hulette commented on BEAM-10986:
--------------------------------------

Maybe I should've known this but I didn't. [maven 
coords|https://maven.apache.org/pom.html#Maven_Coordinates] means 
{{groupId:artifactId:version}}.

I think it's worth noting that even though the heuristic isn't guaranteed, at 
least xlang tests will break at HEAD if the heuristic becomes false, since the 
artifactid is part of the local filepath for development builds: 
https://github.com/apache/beam/blob/6612b24ada9382706373db547b5606d6e0496b02/sdks/python/apache_beam/utils/subprocess_server.py#L218

So you're suggesting we should be using maven coords as the primary identifier 
if a bundled jar is the form of executable distribution? Is there a way to make 
that work well with development builds (other than just using the heuristic in 
the opposite direction)?

> :build task doesn't build shaded jar with shadow >5.0.0
> -------------------------------------------------------
>
>                 Key: BEAM-10986
>                 URL: https://issues.apache.org/jira/browse/BEAM-10986
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P0
>             Fix For: 2.25.0
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Not 100% sure but I believe this will prevent us from releasing shaded jars.
> See 
> [https://lists.apache.org/thread.html/r12c785c2b01017329204ad816740e80b70c19c5f2bb1ea01535a987d%40%3Cdev.beam.apache.org%3E]
>  for details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to