[
https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=192953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192953
]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 17:38
Start Date: 31/Jan/19 17:38
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7684: [BEAM-5658]
Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684#discussion_r252766910
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java
##########
@@ -43,6 +44,8 @@
* DebugCapture encapsulates a simple periodic sender for HTML pages to the
debug capture service.
* It is dynamically configured by the service.
*/
+// The fields are written but only implicitly read. Not a bug.
+@SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
Review comment:
Can this supporession be added to the fields themselves? It's unclear what
this is applied to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 192953)
Time Spent: 1h 20m (was: 1h 10m)
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after
> fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
