[
https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=192954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192954
]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 17:38
Start Date: 31/Jan/19 17:38
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7684: [BEAM-5658]
Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684#discussion_r252767612
##########
File path:
sdks/java/build-tools/src/main/java/org/apache/beam/buildtools/NonnullByDefault.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.buildtools;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import javax.annotation.Nonnull;
+import javax.annotation.meta.TypeQualifierDefault;
+
+@Documented
+@Nonnull
+@TypeQualifierDefault({
+ ElementType.ANNOTATION_TYPE,
+ ElementType.CONSTRUCTOR,
+ ElementType.FIELD,
+ ElementType.LOCAL_VARIABLE,
+ ElementType.METHOD,
+ ElementType.PACKAGE,
+ ElementType.PARAMETER,
+ ElementType.TYPE
+})
+@Retention(RetentionPolicy.RUNTIME)
+public @interface NonnullByDefault {}
Review comment:
Perhaps worth a brief comment explaining what this interface is actually for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 192954)
Time Spent: 1.5h (was: 1h 20m)
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after
> fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
