[
https://issues.apache.org/jira/browse/BEAM-11530?focusedWorklogId=529159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529159
]
ASF GitHub Bot logged work on BEAM-11530:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/20 15:17
Start Date: 29/Dec/20 15:17
Worklog Time Spent: 10m
Work Description: krakowski commented on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-752116959
Hi @TheNeuralBit,
I tried reproducing the issue adding a unit test to `JavaBeanSchemaTest` but
there it passes (with `getAnnotatedType()`), which I find pretty strange.
Because of this I created a separate repo for reproduction at
https://github.com/krakowski/BEAM-11530.
Running `./gradlew run` within this projects results in the following
stacktrace.
```
Exception in thread "main" java.lang.RuntimeException: JavaBean contained
setter for field value that had a mismatching nullable attribute.
at
org.apache.beam.sdk.schemas.utils.JavaBeanUtils.validateJavaBean(JavaBeanUtils.java:96)
at
org.apache.beam.sdk.schemas.JavaBeanSchema.schemaFor(JavaBeanSchema.java:120)
at
org.apache.beam.sdk.schemas.annotations.DefaultSchema$DefaultSchemaProvider.schemaFor(DefaultSchema.java:133)
...
```
The JavaBean used within this example is pretty simple and does contain only
one field.
```java
package io.github.krakowski.beam;
import org.apache.avro.reflect.Nullable;
import org.apache.beam.sdk.schemas.JavaBeanSchema;
import org.apache.beam.sdk.schemas.annotations.DefaultSchema;
@DefaultSchema(JavaBeanSchema.class)
public final class SimpleBean {
@Nullable
private Float value;
public @Nullable Float getValue() {
return value;
}
public void setValue(@Nullable Float value) {
this.value = value;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529159)
Time Spent: 40m (was: 0.5h)
> Annotated setter parameters handled wrong in schema creation
> ------------------------------------------------------------
>
> Key: BEAM-11530
> URL: https://issues.apache.org/jira/browse/BEAM-11530
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.26.0
> Environment: Linux & OpenJDK 15
> Reporter: Filip Krakowski
> Priority: P0
> Labels: annotation, fieldtype, parameter, schema
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I'm facing an exception telling me that my JavaBean contained a setter for a
> field that had a mismatching nullable attribute, although both getter and
> setter (parameters) are annotated with @Nullable.
>
> The code responsible for determining if a setter's parameter is nullable
> looks wrong to me, since it does check if the type (class) itself is
> annotated with @Nullable instead of checking the actual parameter's
> annotations.
>
> [FieldValueTypeInformation|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java#L234-L236]
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotatedType().getAnnotations())
> .anyMatch(annotation -> isNullableAnnotation(annotation));{code}
>
> In my understanding this should look like this.
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotations())
> .anyMatch(FieldValueTypeInformation::isNullableAnnotation);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
