[
https://issues.apache.org/jira/browse/BEAM-11530?focusedWorklogId=529187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529187
]
ASF GitHub Bot logged work on BEAM-11530:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/20 16:49
Start Date: 29/Dec/20 16:49
Worklog Time Spent: 10m
Work Description: krakowski edited a comment on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-752154819
Just to be sure I created a `@Nullable` annotation inside
`org.apache.beam.sdk.schemas.utils` (which should be on the classpath) and
replaced `org.apache.avro.reflect.Nullable` with
`org.apache.beam.sdk.schemas.utils.Nullable`.
```java
package org.apache.beam.sdk.schemas.utils;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@Retention(RetentionPolicy.RUNTIME)
public @interface Nullable {}
```
Unfortunately the test is still failing with the same message because
`method.getParameters()[0].getAnnotatedType().getAnnotations()` is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529187)
Time Spent: 1h 20m (was: 1h 10m)
> Annotated setter parameters handled wrong in schema creation
> ------------------------------------------------------------
>
> Key: BEAM-11530
> URL: https://issues.apache.org/jira/browse/BEAM-11530
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.26.0
> Environment: Linux & OpenJDK 15
> Reporter: Filip Krakowski
> Priority: P0
> Labels: annotation, fieldtype, parameter, schema
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I'm facing an exception telling me that my JavaBean contained a setter for a
> field that had a mismatching nullable attribute, although both getter and
> setter (parameters) are annotated with @Nullable.
>
> The code responsible for determining if a setter's parameter is nullable
> looks wrong to me, since it does check if the type (class) itself is
> annotated with @Nullable instead of checking the actual parameter's
> annotations.
>
> [FieldValueTypeInformation|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java#L234-L236]
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotatedType().getAnnotations())
> .anyMatch(annotation -> isNullableAnnotation(annotation));{code}
>
> In my understanding this should look like this.
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotations())
> .anyMatch(FieldValueTypeInformation::isNullableAnnotation);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
