[
https://issues.apache.org/jira/browse/BEAM-11530?focusedWorklogId=529179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529179
]
ASF GitHub Bot logged work on BEAM-11530:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/20 16:28
Start Date: 29/Dec/20 16:28
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-752146612
Ah thanks for the investigation. When looking into BEAM-10632 I learned that
the Java spec requires the runtime to ignore an annotation whose type isn't on
the classpath:
> When an annotation is put on a member but the annotation type is missing
on the class path, the specification requires the runtime to ignore this
annotation, i.e. to act as if the annotation is not present.
Is it possible `org.apache.avro.reflect.Nullable` isn't on the classpath?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529179)
Time Spent: 1h (was: 50m)
> Annotated setter parameters handled wrong in schema creation
> ------------------------------------------------------------
>
> Key: BEAM-11530
> URL: https://issues.apache.org/jira/browse/BEAM-11530
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.26.0
> Environment: Linux & OpenJDK 15
> Reporter: Filip Krakowski
> Priority: P0
> Labels: annotation, fieldtype, parameter, schema
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I'm facing an exception telling me that my JavaBean contained a setter for a
> field that had a mismatching nullable attribute, although both getter and
> setter (parameters) are annotated with @Nullable.
>
> The code responsible for determining if a setter's parameter is nullable
> looks wrong to me, since it does check if the type (class) itself is
> annotated with @Nullable instead of checking the actual parameter's
> annotations.
>
> [FieldValueTypeInformation|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java#L234-L236]
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotatedType().getAnnotations())
> .anyMatch(annotation -> isNullableAnnotation(annotation));{code}
>
> In my understanding this should look like this.
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotations())
> .anyMatch(FieldValueTypeInformation::isNullableAnnotation);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
