[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=530121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530121
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/21 05:50
Start Date: 02/Jan/21 05:50
Worklog Time Spent: 10m
Work Description: shehzaadn-vd commented on a change in pull request
#12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847357
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -93,22 +92,26 @@ dependencies {
compile library.java.joda_time
shadow library.java.vendored_guava_26_0_jre
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-common-protos:1.17.0"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk:1.1.3:linux-x86_64"
compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+ //compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
compile "org.eclipse.jetty:jetty-server:9.2.10.v20150310"
compile "org.eclipse.jetty:jetty-servlet:9.2.10.v20150310"
- compile library.java.error_prone_annotations
+ compile "com.google.auth:google-auth-library-credentials:0.19.0"
+ compile "com.google.guava:guava:25.1-jre"
+ compile "io.opencensus:opencensus-api:0.24.0"
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:2.2.1"
compile library.java.slf4j_jdk14
-
+ permitUnusedDeclared library.java.slf4j_jdk14
Review comment:
nitpick - there should be a be a blank line about the comment - like
there was before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530121)
Time Spent: 31h 40m (was: 31.5h)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 31h 40m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
