[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=530126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530126
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/21 05:52
Start Date: 02/Jan/21 05:52
Worklog Time Spent: 10m
Work Description: shehzaadn-vd commented on a change in pull request
#12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847509
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,55 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
+ //compile library.java.grpc_google_cloud_pubsublite_v1
Review comment:
this line should be removed - not commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530126)
Time Spent: 32h 20m (was: 32h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 32h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
