[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=530314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530314
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/21 00:03
Start Date: 03/Jan/21 00:03
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-753546217
> @ibzib , I consider it is quite large and critical change to be merged all
at once. Responding to your suggestion of splitting this PR into multiple
separate PR, I am thinking to split this PR into 8 sub PRs as:
>
> 1. Module A | beam/example/java
> 2. Module B | beam/model
> 3. Module C | beam/runners/core-construction-java, runners/core-java,
runners/direct-java, runners/extensions-java
> 4. Module D | runners/flink,
runners/google-cloud-dataflow-java,runners/google-cloud-dataflow-java,
runners/java-fn-execution, runners/java-job-service, runners/jet
> 5. Module E | runners/local-java, runners/portability, runners/samza,
runners/spark, runners/twister2
> 6. Module F | sdks/java/bom, sdks/java/build-tools, sdks/java/container,
sdks/java/core
> 7. Module G | sdks/java/expansion-service, sdks/java/extensions,
sdks/java/fn-execution, sdks/java/harness
> 8. Module H | sdks/java/io, sdks/java/javadoc, sdks/java/maven-archetypes,
sdks/java/testing
It's up to your discretion, but in general, I would break it into the
smallest PRs possible. In other words, wherever you can change one subproject
independently of all the others, do so. Specifically, each runner
(`runners/flink`, `runners/spark`, etc.) should probably get its own PR to be
reviewed by one of the maintainers of that runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530314)
Time Spent: 33h 20m (was: 33h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 33h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
