[
https://issues.apache.org/jira/browse/BEAM-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275451#comment-17275451
]
Yifan Mai commented on BEAM-11715:
----------------------------------
I'm not too familiar with how to test x-lang stuff, but we currently check that
the environment has the python_urns.PACKED_COMBINE_FN capability and that the
CombineFn URN is python_urns.PICKLED_COMBINE_FN
[here|https://github.com/apache/beam/blob/a44768f074ad0c55d5ca19c8ec6a47887b7e8538/sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py#L878-L886].
I believe that should prevent combiner packing from triggering in the x-lang
case.
> Combiner packing creates an incorrect proto
> -------------------------------------------
>
> Key: BEAM-11715
> URL: https://issues.apache.org/jira/browse/BEAM-11715
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Yifan Mai
> Priority: P0
> Fix For: 2.28.0
>
>
> Seems like optimization creates a CombinePerKey transform that does not have
> any sub-transforms. We should fix this by preserving the old structure for
> CombinePerKey (GBK+CombineValues composite).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
