[
https://issues.apache.org/jira/browse/BEAM-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275454#comment-17275454
]
Chamikara Madhusanka Jayalath commented on BEAM-11715:
------------------------------------------------------
Note that CombinePerKeyPTransformOverride will not work for x-lang since seems
like it requires a "proto -> from runner API -> pipeline -> to runner API ->
proto" conversion (which doesn't work for protos with embedded external
transforms). Also seems like CombinePerKeyPTransformOverride is guarded by an
experiment hence original proto will continue to be incorrect when that
experiment is not set IIUC.
> Combiner packing creates an incorrect proto
> -------------------------------------------
>
> Key: BEAM-11715
> URL: https://issues.apache.org/jira/browse/BEAM-11715
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Yifan Mai
> Priority: P0
> Fix For: 2.28.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have
> any sub-transforms. We should fix this by preserving the old structure for
> CombinePerKey (GBK+CombineValues composite).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
