[ 
https://issues.apache.org/jira/browse/BEAM-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278236#comment-17278236
 ] 

Yifan Mai commented on BEAM-11715:
----------------------------------

Fixing translations.pack_combiners turns out to be more complicated than I 
thought. More details in #13877. TLDR the subtransforms for Dataflow are 
different than the subtransforms for FnApiRunner.

Instead of fixing translations.pack_combiners, I will instead partially revert 
#13763 (which is the PR that added translations.pack_combiners to Dataflow). 
This should get Dataflow back into a working state and unblock the release. The 
revert PR is #13884.

> Combiner packing creates an incorrect proto
> -------------------------------------------
>
>                 Key: BEAM-11715
>                 URL: https://issues.apache.org/jira/browse/BEAM-11715
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Yifan Mai
>            Priority: P1
>             Fix For: 2.28.0
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have 
> any sub-transforms. We should fix this by preserving the old structure for 
> CombinePerKey (GBK+CombineValues composite).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to