[
https://issues.apache.org/jira/browse/BEAM-12276?focusedWorklogId=592859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592859
]
ASF GitHub Bot logged work on BEAM-12276:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/21 16:58
Start Date: 04/May/21 16:58
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-832094502
The general invariant for watermark-correct operators was that processing
of an element with timestamp T does not produce a timestamp > T. This check
was an attempt to extend that timer processing.
Making this a hard check is maybe too strict, but I'm still not sure I
understand the use case. Allowing future timestamps means that you have a
watermark hold for timestamps T+delta, but you remove the watermark hold
when the watermark reaches T. I guess we could allow it, but it still seems
odd to me.
On Tue, May 4, 2021 at 9:52 AM Kenn Knowles ***@***.***>
wrote:
> Nonetheless the check here doesn't have any basis in real requirements,
> right?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/14718#issuecomment-832090563>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVJYAUOUHL2ET4HD5FLTMAQ3PANCNFSM44CKPPKQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 592859)
Time Spent: 1h 10m (was: 1h)
> Timer.withOutputTimestamp(Instant).offset(Duration).setRelative() might fail
> unexpectedly
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-12276
> URL: https://issues.apache.org/jira/browse/BEAM-12276
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.30.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We check that timer's output timestamp is not before timer fire timestamp.
> The fire timestamp is unknown to user when setting a relative timer and
> therefore cannot be checked in user code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
