[
https://issues.apache.org/jira/browse/BEAM-12276?focusedWorklogId=592882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592882
]
ASF GitHub Bot logged work on BEAM-12276:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/21 17:37
Start Date: 04/May/21 17:37
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-832120099
FYI, I'm not opposed to loosening this check. I just want to make sure I
understand the use case.
On Tue, May 4, 2021 at 10:20 AM Reuven Lax ***@***.***> wrote:
> The fire timestamp for the timer should be the timestamp of the timer
> itself, not the current input watermark. One way to get is is using
> OnTimerContext.fireTimestamp. You can also get it by adding a @Timestamp
> parameter to the onTimer function, which will be filled in using the fire
> timestamp.
>
> On Tue, May 4, 2021 at 10:17 AM Jan Lukavský ***@***.***>
> wrote:
>
>> @reuvenlax <https://github.com/reuvenlax> the problem is with relative
>> timers. I'm not aware of a way to get the input watermark, which is the
>> firing timestamp for relative event time timer with zero offset. Which is
>> tested in the test case.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/beam/pull/14718#issuecomment-832106898>, or
>> unsubscribe
>>
<https://github.com/notifications/unsubscribe-auth/AFAYJVKCLW2M3WAUWK3NATLTMAT4HANCNFSM44CKPPKQ>
>> .
>>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 592882)
Time Spent: 1h 40m (was: 1.5h)
> Timer.withOutputTimestamp(Instant).offset(Duration).setRelative() might fail
> unexpectedly
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-12276
> URL: https://issues.apache.org/jira/browse/BEAM-12276
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.30.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We check that timer's output timestamp is not before timer fire timestamp.
> The fire timestamp is unknown to user when setting a relative timer and
> therefore cannot be checked in user code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
