[
https://issues.apache.org/jira/browse/BEAM-12276?focusedWorklogId=592890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592890
]
ASF GitHub Bot logged work on BEAM-12276:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/21 17:43
Start Date: 04/May/21 17:43
Worklog Time Spent: 10m
Work Description: je-ik commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-832123747
There is no fireTimestamp until the timer is actually fired. The use case
sets the timer in @ProcessElement.
`Timer.withOutputTimestamp().offset(Duration.ZERO).setRelative()` should fire
as soon as watermark moves, the fireTimestamp of the set timer is the current
value of the input watermark (presumably, I didn't investigate the code, but it
makes sense). Whether or not this call throws exception depends on the current
value of the input watermark (or the base for relative event time timers, may
it be anything).
If you look at the test case I think there is nothing else left to do to
make it succeed without changing the precondition check (or making input
watermark available to the user somehow).
Another note is that setting watermarkhold to time T + delta is semantically
a no-op, the output watermark cannot be ahead of the input watermark, so that
doesn't break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 592890)
Time Spent: 1h 50m (was: 1h 40m)
> Timer.withOutputTimestamp(Instant).offset(Duration).setRelative() might fail
> unexpectedly
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-12276
> URL: https://issues.apache.org/jira/browse/BEAM-12276
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.30.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We check that timer's output timestamp is not before timer fire timestamp.
> The fire timestamp is unknown to user when setting a relative timer and
> therefore cannot be checked in user code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
