[ 
https://issues.apache.org/jira/browse/BEAM-12384?focusedWorklogId=600565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600565
 ]

ASF GitHub Bot logged work on BEAM-12384:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/21 18:07
            Start Date: 21/May/21 18:07
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on a change in pull request #14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r637110068



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T> 
source) {
           .apply(ParDo.of(new OutputSingleSource<>(source)))
           .setCoder(SerializableCoder.of(new 
TypeDescriptor<BoundedSource<T>>() {}))
           .apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
-          .setCoder(source.getOutputCoder());
+          .setCoder(source.getOutputCoder())
+          
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());

Review comment:
       Do we maintain the `TypeDescriptor` information before? I was under 
impression that for most of cases we only set `Coder` for a output 
`PCollection`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 600565)
    Time Spent: 0.5h  (was: 20m)

> Read.Bounded typeDescriptor is lost after move to SDF
> -----------------------------------------------------
>
>                 Key: BEAM-12384
>                 URL: https://issues.apache.org/jira/browse/BEAM-12384
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: P2
>             Fix For: 2.31.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> While debugging a downstream transform after Read I notice that the 
> typeDescriptor information was not set up correctly on the Read transform



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to