[
https://issues.apache.org/jira/browse/BEAM-12384?focusedWorklogId=601424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601424
]
ASF GitHub Bot logged work on BEAM-12384:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 21:47
Start Date: 24/May/21 21:47
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r638299198
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T>
source) {
.apply(ParDo.of(new OutputSingleSource<>(source)))
.setCoder(SerializableCoder.of(new
TypeDescriptor<BoundedSource<T>>() {}))
.apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
- .setCoder(source.getOutputCoder());
+ .setCoder(source.getOutputCoder())
+
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());
Review comment:
I like @boyuanzz fix because even in the presence of different Coders
the TypeDescriptor is commonly preserved inside of the Coders. WDYT
@kennknowles can you spot some particular issues about it?
I can rebase this PR targetting a generic implementation like the one on
#14870 but I did not do it like that because I was not really familiar with the
reasoning behind not relying on the coder typeDescriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601424)
Time Spent: 2h 20m (was: 2h 10m)
> Read.Bounded typeDescriptor is lost after move to SDF
> -----------------------------------------------------
>
> Key: BEAM-12384
> URL: https://issues.apache.org/jira/browse/BEAM-12384
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Fix For: 2.31.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> While debugging a downstream transform after Read I notice that the
> typeDescriptor information was not set up correctly on the Read transform
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
