[
https://issues.apache.org/jira/browse/BEAM-12384?focusedWorklogId=600666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600666
]
ASF GitHub Bot logged work on BEAM-12384:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/21 21:56
Start Date: 21/May/21 21:56
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r637254477
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T>
source) {
.apply(ParDo.of(new OutputSingleSource<>(source)))
.setCoder(SerializableCoder.of(new
TypeDescriptor<BoundedSource<T>>() {}))
.apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
- .setCoder(source.getOutputCoder());
+ .setCoder(source.getOutputCoder())
+
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());
Review comment:
Yes, the expected use of this method is to set the type descriptor but
_not_ the coder. This way, the coder registry still can choose the coder.
Setting both is redundant, in theory. Setting just the coder should suffice.
Maybe some plumbing needed? It was not really expected to look at either one in
this way.
Another angle to consider is that type descriptor is Java-specific, while
coder is the portable "type" of the data. I don't know if that matters here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 600666)
Time Spent: 2h (was: 1h 50m)
> Read.Bounded typeDescriptor is lost after move to SDF
> -----------------------------------------------------
>
> Key: BEAM-12384
> URL: https://issues.apache.org/jira/browse/BEAM-12384
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Fix For: 2.31.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> While debugging a downstream transform after Read I notice that the
> typeDescriptor information was not set up correctly on the Read transform
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
