[
https://issues.apache.org/jira/browse/BEAM-6838?focusedWorklogId=215041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215041
]
ASF GitHub Bot logged work on BEAM-6838:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 21:32
Start Date: 18/Mar/19 21:32
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8064: [BEAM-6838]
Go SDK: Improving error msgs in pipeline serialization.
URL: https://github.com/apache/beam/pull/8064#discussion_r266640224
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/coder.go
##########
@@ -366,7 +370,7 @@ func (b *CoderMarshaller) Add(c *coder.Coder) string {
return b.internBuiltInCoder(urnVarIntCoder)
default:
- panic(fmt.Sprintf("Unexpected coder kind: %v", c.Kind))
+ panic(fmt.Sprintf("failed to marshal custom coder %v,
unexpected coder kind: %v", *c, c.Kind))
Review comment:
The other panics are getting capitalized (Failed vs failed), please
capitalize for consistency.
Errors should always be lowercased due to the concatenation convention.
Makes them easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 215041)
Time Spent: 1.5h (was: 1h 20m)
> Improve error messages for unregistered protos
> ----------------------------------------------
>
> Key: BEAM-6838
> URL: https://issues.apache.org/jira/browse/BEAM-6838
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When users have a type that can't be serialized (it has a function Field or
> similar) or more complex protocol buffers, the error should be improved to
> display the type being registered, and better yet, the beam.RegisterType(...)
> code they can use to enable use of their type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
