[
https://issues.apache.org/jira/browse/BEAM-6838?focusedWorklogId=215042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215042
]
ASF GitHub Bot logged work on BEAM-6838:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 21:32
Start Date: 18/Mar/19 21:32
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8064: [BEAM-6838]
Go SDK: Improving error msgs in pipeline serialization.
URL: https://github.com/apache/beam/pull/8064#discussion_r266650004
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/coder.go
##########
@@ -157,7 +157,7 @@ func (b *CoderUnmarshaller) makeCoder(c *pb.Coder)
(*coder.Coder, error) {
case urnKVCoder:
if len(components) != 2 {
- return nil, fmt.Errorf("bad pair: %v", c)
+ return nil, fmt.Errorf("could not make coder from proto
%v, incorrect number of components for pair", *c)
Review comment:
Further, take care when dereferencing pointers for use in printing: Some may
have String() methods so you won't have to. See the following as an example:
https://play.golang.org/p/WC2gf2wOBNf
This applies everywhere, even to the protos, which typically have a String()
method generated for their pointer types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 215042)
Time Spent: 1h 40m (was: 1.5h)
> Improve error messages for unregistered protos
> ----------------------------------------------
>
> Key: BEAM-6838
> URL: https://issues.apache.org/jira/browse/BEAM-6838
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When users have a type that can't be serialized (it has a function Field or
> similar) or more complex protocol buffers, the error should be improved to
> display the type being registered, and better yet, the beam.RegisterType(...)
> code they can use to enable use of their type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
