[
https://issues.apache.org/jira/browse/BEAM-6838?focusedWorklogId=215039&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215039
]
ASF GitHub Bot logged work on BEAM-6838:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 21:32
Start Date: 18/Mar/19 21:32
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8064: [BEAM-6838]
Go SDK: Improving error msgs in pipeline serialization.
URL: https://github.com/apache/beam/pull/8064#discussion_r266643368
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/serialize.go
##########
@@ -43,14 +43,14 @@ func EncodeMultiEdge(edge *graph.MultiEdge)
(*v1.MultiEdge, error) {
if edge.DoFn != nil {
ref, err := encodeFn((*graph.Fn)(edge.DoFn))
if err != nil {
- return nil, fmt.Errorf("encode: bad userfn: %v", err)
+ return nil, fmt.Errorf("failed to encode multi edge %v,
bad userfn: %v", *edge, err)
Review comment:
I'm a bit torn on including "multi edge" since the part that's important is
that the user's DoFn isn't able to be encoded, while "multi edge" is an
internal detail a pipeline author doesn't run into. My inclination would be to
drop "multi edge" and simply say
("failed to encode userfn %v:", *edge, err)
Including the *edge as context is good since it should help narrow things
down for the reading user. Let me know if you want help triggering this message.
Here and the similar messages below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 215039)
Time Spent: 1h 10m (was: 1h)
> Improve error messages for unregistered protos
> ----------------------------------------------
>
> Key: BEAM-6838
> URL: https://issues.apache.org/jira/browse/BEAM-6838
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When users have a type that can't be serialized (it has a function Field or
> similar) or more complex protocol buffers, the error should be improved to
> display the type being registered, and better yet, the beam.RegisterType(...)
> code they can use to enable use of their type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
