[ 
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=679296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679296
 ]

ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Nov/21 20:33
            Start Date: 09/Nov/21 20:33
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r746008248



##########
File path: 
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java
##########
@@ -391,6 +391,7 @@ public void testInfiniteSkew() {
 
     static final String TIMER_ID = "throwingTimerId";
 
+    @SuppressWarnings("unused")

Review comment:
       I talked to Kenn about this offline. It looks like the internal Google 
guava/errorpone has a feature that would allow us to avoid this. I opened an 
issue with error-prone here: https://github.com/google/error-prone/issues/2668




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 679296)
    Time Spent: 26h 20m  (was: 26h 10m)

> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
>                 Key: BEAM-11936
>                 URL: https://issues.apache.org/jira/browse/BEAM-11936
>             Project: Beam
>          Issue Type: Task
>          Components: build-system, runner-core, sdk-java-core, 
> sdk-java-harness
>            Reporter: Brian Hulette
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 26h 20m
>  Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148) 
> required ignoring a lot of new warnings. We should fix the offending code and 
> re-enable these warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to