[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=679396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679396
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/21 00:59
Start Date: 10/Nov/21 00:59
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r746165575
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java
##########
@@ -391,6 +391,7 @@ public void testInfiniteSkew() {
static final String TIMER_ID = "throwingTimerId";
+ @SuppressWarnings("unused")
Review comment:
Ok I was able to make a change to error-prone to make it suppress this
warning for TimerId and StateId:
https://github.com/google/error-prone/commit/fad4116129fcbaa5e3418ff419f164552f75481a
We can't take advantage of that until it is in an error-prone release
though. We _can_ go ahead and merge PRs that remove unused variables though, so
that we're ready to turn the check on when that fix is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679396)
Time Spent: 26h 50m (was: 26h 40m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 26h 50m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
