[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=679297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679297
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 20:37
Start Date: 09/Nov/21 20:37
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r746013904
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java
##########
@@ -391,6 +391,7 @@ public void testInfiniteSkew() {
static final String TIMER_ID = "throwingTimerId";
+ @SuppressWarnings("unused")
Review comment:
Depending on how that goes we may want to hold off on actually turning
this check on so we don't need to add >100 suppressions on `TimerId` and
`StateId` checks. We could still move forward with removing unused variables
that he check identifies either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679297)
Time Spent: 26.5h (was: 26h 20m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 26.5h
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
