[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=687513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687513
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 18:27
Start Date: 29/Nov/21 18:27
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #16034:
URL: https://github.com/apache/beam/pull/16034#discussion_r758621576
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
##########
@@ -362,7 +362,7 @@ public void testInArray() {
PCollection<Row> stream = execute(sql);
- final Schema schema = Schema.builder().addNullableField("field1",
FieldType.BOOLEAN).build();
+ Schema.builder().addNullableField("field1", FieldType.BOOLEAN).build();
Review comment:
nit: same, just delete.
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -244,6 +244,7 @@ private RowCoder getErrorRowCoder(PCollection<Row>
upstream, InputGetterImpl inp
private final boolean verifyRowValues;
private final List<String> jarPaths;
+ @SuppressWarnings("unused")
Review comment:
This and the one in BeamZetaSqlCalcRel are both accessed by reflection.
Would making them `public` fix this without the suppression?
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/PatternCondition.java
##########
@@ -26,6 +26,7 @@
*/
public abstract class PatternCondition implements Serializable {
+ @SuppressWarnings("unused") // Affects a public api
Review comment:
Is it possible to delete this variable and instead put the annotation on
the constructor?
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
##########
@@ -346,7 +346,7 @@ public void testIn() {
PCollection<Row> stream = execute(sql);
- final Schema schema = Schema.builder().addNullableField("field1",
FieldType.BOOLEAN).build();
+ Schema.builder().addNullableField("field1", FieldType.BOOLEAN).build();
Review comment:
nit: This doesn't have side effects, you can just delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687513)
Time Spent: 40h 20m (was: 40h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 40h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
