[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=687516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687516
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 18:43
Start Date: 29/Nov/21 18:43
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16034:
URL: https://github.com/apache/beam/pull/16034#discussion_r758639731
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -244,6 +244,7 @@ private RowCoder getErrorRowCoder(PCollection<Row>
upstream, InputGetterImpl inp
private final boolean verifyRowValues;
private final List<String> jarPaths;
+ @SuppressWarnings("unused")
Review comment:
This looks like another place we should add TODO(BEAM-13271) (In the
next errorprone releasethere will be a way to indicate that annotations like
FieldAccess are used reflectively)
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -244,6 +244,7 @@ private RowCoder getErrorRowCoder(PCollection<Row>
upstream, InputGetterImpl inp
private final boolean verifyRowValues;
private final List<String> jarPaths;
+ @SuppressWarnings("unused")
Review comment:
This looks like another place we should add TODO(BEAM-13271) (In the
next errorprone release there will be a way to indicate that annotations like
FieldAccess are used reflectively)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687516)
Time Spent: 40.5h (was: 40h 20m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 40.5h
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
