[
https://issues.apache.org/jira/browse/BEAM-13236?focusedWorklogId=687879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687879
]
ASF GitHub Bot logged work on BEAM-13236:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 09:37
Start Date: 30/Nov/21 09:37
Worklog Time Spent: 10m
Work Description: mosche commented on a change in pull request #15955:
URL: https://github.com/apache/beam/pull/15955#discussion_r759092871
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -884,28 +885,81 @@ public PDone expand(PCollection<byte[]> input) {
getPartitionKey() == null || (getPartitioner() == null),
"only one of either withPartitionKey() or withPartitioner() is
possible");
checkArgument(getAWSClientsProvider() != null, "withAWSClientsProvider()
is required");
+ producerConfiguration(); // verify Kinesis producer configuration can be
build
Review comment:
Sorry, misunderstood then ... Honestly, I'd rather create the config
again, especially as it's only required once per JVM. Costs are insignificant
and it avoids any potential lifecycle bugs when using a transient field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687879)
Time Spent: 5h (was: 4h 50m)
> Properly close kinesis producer on teardown
> -------------------------------------------
>
> Key: BEAM-13236
> URL: https://issues.apache.org/jira/browse/BEAM-13236
> Project: Beam
> Issue Type: Task
> Components: io-java-kinesis
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Labels: aws, ios, kinesis
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Each KPL producer uses it's own native deamon, so properly cleaning up once
> not used anymore is important.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
