[
https://issues.apache.org/jira/browse/BEAM-13236?focusedWorklogId=687887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687887
]
ASF GitHub Bot logged work on BEAM-13236:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 09:42
Start Date: 30/Nov/21 09:42
Worklog Time Spent: 10m
Work Description: mosche commented on a change in pull request #15955:
URL: https://github.com/apache/beam/pull/15955#discussion_r759097825
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -1067,8 +1063,11 @@ private void checkForFailures(String message) throws
IOException {
@Teardown
public void teardown() throws Exception {
- if (producer != null && producer.getOutstandingRecordsCount() > 0) {
- producer.flushSync();
+ if (producer != null) {
+ if (producer.getOutstandingRecordsCount() > 0) {
+ producer.flushSync();
+ }
+ producer.destroy();
}
producer = null;
Review comment:
Thats absolutely clear 👍
> some execution engines write at parallelism one resulting into a single
instance of the write DoFn
Though my question is how could the execution engine distinguish a DoFn that
implements a write from any other DoFn to reduce parallelism and accomplish the
above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687887)
Time Spent: 5h 10m (was: 5h)
> Properly close kinesis producer on teardown
> -------------------------------------------
>
> Key: BEAM-13236
> URL: https://issues.apache.org/jira/browse/BEAM-13236
> Project: Beam
> Issue Type: Task
> Components: io-java-kinesis
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Labels: aws, ios, kinesis
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Each KPL producer uses it's own native deamon, so properly cleaning up once
> not used anymore is important.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
