[
https://issues.apache.org/jira/browse/BEAM-13236?focusedWorklogId=687940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687940
]
ASF GitHub Bot logged work on BEAM-13236:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 10:48
Start Date: 30/Nov/21 10:48
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #15955:
URL: https://github.com/apache/beam/pull/15955#discussion_r759155396
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -1067,8 +1063,11 @@ private void checkForFailures(String message) throws
IOException {
@Teardown
public void teardown() throws Exception {
- if (producer != null && producer.getOutstandingRecordsCount() > 0) {
- producer.flushSync();
+ if (producer != null) {
+ if (producer.getOutstandingRecordsCount() > 0) {
+ producer.flushSync();
+ }
+ producer.destroy();
}
producer = null;
Review comment:
I checked the runner code. What happens is that the `Write` returns a
`PDone` (empty `PCollection`). the Write is executed with a native `map` and
the output of the map is the last native `Dataset` of the native (generated)
pipeline on which we call a passthrough native `writer` but the actual write
operation has already been done in reality (when we executed the map).
Conclusion the engine will set the parallelism on the writer that does nothing.
So I was wrong, the parallelism of the writing operation will be the one set by
the engine for the final map of the DAG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687940)
Time Spent: 6h 20m (was: 6h 10m)
> Properly close kinesis producer on teardown
> -------------------------------------------
>
> Key: BEAM-13236
> URL: https://issues.apache.org/jira/browse/BEAM-13236
> Project: Beam
> Issue Type: Task
> Components: io-java-kinesis
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Labels: aws, ios, kinesis
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Each KPL producer uses it's own native deamon, so properly cleaning up once
> not used anymore is important.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
