[ 
https://issues.apache.org/jira/browse/BEAM-14251?focusedWorklogId=757148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757148
 ]

ASF GitHub Bot logged work on BEAM-14251:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/22 18:36
            Start Date: 14/Apr/22 18:36
    Worklog Time Spent: 10m 
      Work Description: ihji commented on code in PR #17280:
URL: https://github.com/apache/beam/pull/17280#discussion_r850707272


##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -431,10 +431,15 @@ def __init__(self, urn, payload, expansion_service=None):
     self._payload = (
         payload.payload() if isinstance(payload, PayloadBuilder) else payload)
     self._expansion_service = expansion_service
+    self._output_coder = None
     self._external_namespace = self._fresh_namespace()
     self._inputs = {}  # type: Dict[str, pvalue.PCollection]
     self._outputs = {}  # type: Dict[str, pvalue.PCollection]
 
+  def with_output_coder(self, output_coder):

Review Comment:
   Done.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 757148)
    Time Spent: 1h 40m  (was: 1.5h)

> add output_coder_override to ExpansionRequest
> ---------------------------------------------
>
>                 Key: BEAM-14251
>                 URL: https://issues.apache.org/jira/browse/BEAM-14251
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> add output_coder_override to ExpansionRequest



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to