[ 
https://issues.apache.org/jira/browse/BEAM-14251?focusedWorklogId=758092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758092
 ]

ASF GitHub Bot logged work on BEAM-14251:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Apr/22 19:37
            Start Date: 18/Apr/22 19:37
    Worklog Time Spent: 10m 
      Work Description: ihji commented on code in PR #17280:
URL: https://github.com/apache/beam/pull/17280#discussion_r852359798


##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java:
##########
@@ -225,9 +251,25 @@ public OutputT expand(InputT input) {
         }
       }
 
+      ExpansionApi.ExpansionRequest.Builder requestBuilder =
+          ExpansionApi.ExpansionRequest.newBuilder();
+      if (!outputCoders.isEmpty()) {

Review Comment:
   Done.



##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java:
##########
@@ -225,9 +251,25 @@ public OutputT expand(InputT input) {
         }
       }
 
+      ExpansionApi.ExpansionRequest.Builder requestBuilder =
+          ExpansionApi.ExpansionRequest.newBuilder();
+      if (!outputCoders.isEmpty()) {
+        requestBuilder.putAllOutputCoderOverride(
+            outputCoders.entrySet().stream()
+                .collect(
+                    Collectors.toMap(
+                        Map.Entry::getKey,
+                        v -> {

Review Comment:
   Done.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 758092)
    Time Spent: 3h 10m  (was: 3h)

> add output_coder_override to ExpansionRequest
> ---------------------------------------------
>
>                 Key: BEAM-14251
>                 URL: https://issues.apache.org/jira/browse/BEAM-14251
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> add output_coder_override to ExpansionRequest



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to