[
https://issues.apache.org/jira/browse/BEAM-14251?focusedWorklogId=757151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757151
]
ASF GitHub Bot logged work on BEAM-14251:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 18:42
Start Date: 14/Apr/22 18:42
Worklog Time Spent: 10m
Work Description: ihji commented on code in PR #17280:
URL: https://github.com/apache/beam/pull/17280#discussion_r850711768
##########
sdks/python/apache_beam/runners/portability/expansion_service.py:
##########
@@ -63,6 +64,10 @@ def with_pipeline(component, pcoll_id=None):
}
transform = with_pipeline(
ptransform.PTransform.from_runner_api(request.transform, context))
+ if request.output_coder_override.spec.urn:
+ output_coder = Coder.from_runner_api(
+ request.output_coder_override, context)
+ transform = transform.with_output_types(output_coder.to_type_hint())
Review Comment:
looks like we're already doing type compatibility check during transform
application to pipeline:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/pipeline.py#L711
Incompatible output type assignment will throw an error at
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/expansion_service.py#L75
Issue Time Tracking
-------------------
Worklog Id: (was: 757151)
Time Spent: 1h 50m (was: 1h 40m)
> add output_coder_override to ExpansionRequest
> ---------------------------------------------
>
> Key: BEAM-14251
> URL: https://issues.apache.org/jira/browse/BEAM-14251
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> add output_coder_override to ExpansionRequest
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
