[
https://issues.apache.org/jira/browse/BEAM-13983?focusedWorklogId=757930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757930
]
ASF GitHub Bot logged work on BEAM-13983:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/22 15:23
Start Date: 18/Apr/22 15:23
Worklog Time Spent: 10m
Work Description: yeandy commented on code in PR #17368:
URL: https://github.com/apache/beam/pull/17368#discussion_r852194193
##########
sdks/python/apache_beam/ml/inference/sklearn_loader_test.py:
##########
@@ -151,6 +151,12 @@ def test_bad_file_raises(self):
SklearnModelLoader(model_uri='/var/bad_file_name'))
pipeline.run()
+ def test_bad_input_type_raises(self):
+ with tempfile.NamedTemporaryFile() as file:
+ with self.assertRaises(TypeError):
Review Comment:
just to be super clear that it's the custom error that you wrote, it might
be better to do `self.assertRaisesRegex(TypeError, 'Unsupported serialization
type.')`
Issue Time Tracking
-------------------
Worklog Id: (was: 757930)
Time Spent: 3h 10m (was: 3h)
> Implement RunInference for Scikit-learn
> ---------------------------------------
>
> Key: BEAM-13983
> URL: https://issues.apache.org/jira/browse/BEAM-13983
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Andy Ye
> Priority: P2
> Labels: run-inference
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Implement RunInference for Scikit-learn as described in the design doc
> [https://s.apache.org/inference-sklearn-pytorch]
> There will be a sklearn_impl.py file that contains SklearnModelLoader and
> SlkearnInferenceRunner classes.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
