[ 
https://issues.apache.org/jira/browse/BEAM-13983?focusedWorklogId=760827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760827
 ]

ASF GitHub Bot logged work on BEAM-13983:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Apr/22 13:24
            Start Date: 22/Apr/22 13:24
    Worklog Time Spent: 10m 
      Work Description: ryanthompson591 commented on code in PR #17368:
URL: https://github.com/apache/beam/pull/17368#discussion_r856226165


##########
sdks/python/apache_beam/ml/inference/sklearn_loader.py:
##########
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import enum
+import pickle
+import sys
+from typing import Any
+from typing import Iterable
+from typing import List
+
+import joblib

Review Comment:
   Done.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 760827)
    Time Spent: 4h 10m  (was: 4h)

> Implement RunInference for Scikit-learn
> ---------------------------------------
>
>                 Key: BEAM-13983
>                 URL: https://issues.apache.org/jira/browse/BEAM-13983
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Andy Ye
>            Assignee: Ryan Thompson
>            Priority: P2
>              Labels: run-inference
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Implement RunInference for Scikit-learn as described in the design doc 
> [https://s.apache.org/inference-sklearn-pytorch]
> There will be a sklearn_impl.py file that contains SklearnModelLoader and 
> SlkearnInferenceRunner classes.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to