[
https://issues.apache.org/jira/browse/BEAM-14251?focusedWorklogId=758093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758093
]
ASF GitHub Bot logged work on BEAM-14251:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/22 19:38
Start Date: 18/Apr/22 19:38
Worklog Time Spent: 10m
Work Description: ihji commented on code in PR #17280:
URL: https://github.com/apache/beam/pull/17280#discussion_r852360154
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -498,11 +502,24 @@ def expand(self, pvalueish):
spec=beam_runner_api_pb2.FunctionSpec(
urn=common_urns.primitives.IMPULSE.urn),
outputs={'out': transform_proto.inputs[tag]}))
+ output_coder = None
+ if self._type_hints.output_types:
+ if self._type_hints.output_types[0]:
+ output_coder = dict((str(k), context.coder_id_from_element_type(v))
+ for k,
Review Comment:
Thanks. Better looking with (k, v) syntax.
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -498,11 +502,24 @@ def expand(self, pvalueish):
spec=beam_runner_api_pb2.FunctionSpec(
urn=common_urns.primitives.IMPULSE.urn),
outputs={'out': transform_proto.inputs[tag]}))
+ output_coder = None
Review Comment:
Done.
Issue Time Tracking
-------------------
Worklog Id: (was: 758093)
Time Spent: 3h 20m (was: 3h 10m)
> add output_coder_override to ExpansionRequest
> ---------------------------------------------
>
> Key: BEAM-14251
> URL: https://issues.apache.org/jira/browse/BEAM-14251
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> add output_coder_override to ExpansionRequest
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
