[
https://issues.apache.org/jira/browse/BEAM-13640?focusedWorklogId=759416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759416
]
ASF GitHub Bot logged work on BEAM-13640:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 17:08
Start Date: 20/Apr/22 17:08
Worklog Time Spent: 10m
Work Description: johnjcasey commented on code in PR #15699:
URL: https://github.com/apache/beam/pull/15699#discussion_r854363882
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/fs/MetadataDynamicCoder.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.fs;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.function.BiConsumer;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.CoderException;
+import org.apache.beam.sdk.coders.StructuredCoder;
+import org.apache.beam.sdk.transforms.SerializableBiConsumer;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+
+public class MetadataDynamicCoder extends
StructuredCoder<MatchResult.Metadata> {
+
+ private static final MetadataCoder V1_CODER = MetadataCoder.of();
+
+ private List<Coder<?>> coders = new ArrayList<>();
Review Comment:
Do we want to use parallel lists? I would typically create a new pojo of
{coder, getter, setter} and have a list of that instead, to avoid off by one
errors if we ever modify this class, or need to add a new aspect to the dynamic
coder that would warrant a new list
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/fs/MetadataDynamicCoderTest.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.fs;
+
+import java.nio.file.Path;
+import org.apache.beam.sdk.coders.VarLongCoder;
+import org.apache.beam.sdk.io.FileSystems;
+import org.apache.beam.sdk.io.fs.MatchResult.Metadata;
+import org.apache.beam.sdk.testing.CoderProperties;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+/** Tests for {@link org.apache.beam.sdk.io.fs.MetadataDynamicCoder}. */
+public class MetadataDynamicCoderTest {
+
+ @Rule public transient TemporaryFolder tmpFolder = new TemporaryFolder();
+
+ @Test
+ public void testEncodeDecodeWithDefaultLastModifiedMills() throws Exception {
Review Comment:
Would it be possible to add a test that uses two dynamic coders, so we can
verify that adding multiple coders stack as expected?
Issue Time Tracking
-------------------
Worklog Id: (was: 759416)
Time Spent: 1h 10m (was: 1h)
> Add MetadataDynamicCoder to support encode-decode for new fields in Metatdata
> -----------------------------------------------------------------------------
>
> Key: BEAM-13640
> URL: https://issues.apache.org/jira/browse/BEAM-13640
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This Issue is to solve similar problems to wha I had in
> [BEAM-12883.|https://issues.apache.org/jira/browse/BEAM-12883?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel]
> Currently there are 2 Coders for Metadata: default one:
> org.apache.beam.sdk.io.fs.MetadataCoder and enhanced one
> org.apache.beam.sdk.io.fs.MetadataCoderV2, the last can also decode-encode
> lastModifiedMillis and it is done in a new coder in order to support backward
> compatibility.
> This will be hard to maintain, we will need to create a new coder for any new
> field that will be added to Metadata.
> So, as suggested in this [comment:
> #15510|https://github.com/apache/beam/pull/15510#issuecomment-928390587], we
> need to have some new generic coder : MetadataDynamicCoder.
> MetadataDynamicCoder can decode/encode any new fields added to Metadata by
> sending getter, setter and coder.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
