[
https://issues.apache.org/jira/browse/BEAM-13640?focusedWorklogId=762168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762168
]
ASF GitHub Bot logged work on BEAM-13640:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/22 08:25
Start Date: 26/Apr/22 08:25
Worklog Time Spent: 10m
Work Description: brachi-wernick commented on code in PR #15699:
URL: https://github.com/apache/beam/pull/15699#discussion_r858430584
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/fs/MetadataDynamicCoderTest.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.fs;
+
+import java.nio.file.Path;
+import org.apache.beam.sdk.coders.VarLongCoder;
+import org.apache.beam.sdk.io.FileSystems;
+import org.apache.beam.sdk.io.fs.MatchResult.Metadata;
+import org.apache.beam.sdk.testing.CoderProperties;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+/** Tests for {@link org.apache.beam.sdk.io.fs.MetadataDynamicCoder}. */
+public class MetadataDynamicCoderTest {
+
+ @Rule public transient TemporaryFolder tmpFolder = new TemporaryFolder();
+
+ @Test
+ public void testEncodeDecodeWithDefaultLastModifiedMills() throws Exception {
Review Comment:
Kind problematic, since all fields now in Metadata are handled. except the
one that I used in the test.
It can work if I won't use the basic `MetadataCoder` in this dynamic coder,
and work only with the fields coders I get in the list, But I think it will be
mess to developers to assign all these basic fields for the dynamic coder, it
is easy now, that they need to send only new/special fields and not all the
basic fields.
(coder now first does : `MatchResult.Metadata.Builder builder =
V1_CODER.decodeBuilder(inStream);`
which covers most of the fields in Metadata. and new fields will be covered
with this coder list of {coder,getter,setter})
Issue Time Tracking
-------------------
Worklog Id: (was: 762168)
Time Spent: 1.5h (was: 1h 20m)
> Add MetadataDynamicCoder to support encode-decode for new fields in Metatdata
> -----------------------------------------------------------------------------
>
> Key: BEAM-13640
> URL: https://issues.apache.org/jira/browse/BEAM-13640
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Priority: P3
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This Issue is to solve similar problems to wha I had in
> [BEAM-12883.|https://issues.apache.org/jira/browse/BEAM-12883?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel]
> Currently there are 2 Coders for Metadata: default one:
> org.apache.beam.sdk.io.fs.MetadataCoder and enhanced one
> org.apache.beam.sdk.io.fs.MetadataCoderV2, the last can also decode-encode
> lastModifiedMillis and it is done in a new coder in order to support backward
> compatibility.
> This will be hard to maintain, we will need to create a new coder for any new
> field that will be added to Metadata.
> So, as suggested in this [comment:
> #15510|https://github.com/apache/beam/pull/15510#issuecomment-928390587], we
> need to have some new generic coder : MetadataDynamicCoder.
> MetadataDynamicCoder can decode/encode any new fields added to Metadata by
> sending getter, setter and coder.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
