[
https://issues.apache.org/jira/browse/BEAM-13640?focusedWorklogId=762527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762527
]
ASF GitHub Bot logged work on BEAM-13640:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/22 20:38
Start Date: 26/Apr/22 20:38
Worklog Time Spent: 10m
Work Description: brachi-wernick opened a new pull request, #15699:
URL: https://github.com/apache/beam/pull/15699
This PR is a continuous work for https://github.com/apache/beam/pull/15510.
Currently there are 2 Coders for Metadata: default one:
`org.apache.beam.sdk.io.fs.MetadataCoder` and enhanced one
`org.apache.beam.sdk.io.fs.MetadataCoderV2`, the last can also decode-encode
`lastModifiedMillis` and it is done in a new coder in order to support backward
compatibility.
This will be hard to maintain, we will need to create a new coder for any
new field that will be added to `Metadata`.
So, as suggested in this comment:
https://github.com/apache/beam/pull/15510#issuecomment-928390587, I came up
with new generic coder : `MetadataDynamicCoder`.
`MetadataDynamicCoder` can decode/encode any new fields added to `Metadata`
by sending getter, setter and coder.
For example creating coder for `lastModifiedMillis`:
``` java
new MetadataDynamicCoder()
.withCoderForField(
VarLongCoder.of(),
Metadata::lastModifiedMillis,
Metadata.Builder::setLastModifiedMillis);
```
I chose to get explicit getter/setter to avoid reflection which has bad
impact on performance.
Issue Time Tracking
-------------------
Worklog Id: (was: 762527)
Time Spent: 2h 20m (was: 2h 10m)
> Add MetadataDynamicCoder to support encode-decode for new fields in Metatdata
> -----------------------------------------------------------------------------
>
> Key: BEAM-13640
> URL: https://issues.apache.org/jira/browse/BEAM-13640
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Priority: P3
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This Issue is to solve similar problems to wha I had in
> [BEAM-12883.|https://issues.apache.org/jira/browse/BEAM-12883?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel]
> Currently there are 2 Coders for Metadata: default one:
> org.apache.beam.sdk.io.fs.MetadataCoder and enhanced one
> org.apache.beam.sdk.io.fs.MetadataCoderV2, the last can also decode-encode
> lastModifiedMillis and it is done in a new coder in order to support backward
> compatibility.
> This will be hard to maintain, we will need to create a new coder for any new
> field that will be added to Metadata.
> So, as suggested in this [comment:
> #15510|https://github.com/apache/beam/pull/15510#issuecomment-928390587], we
> need to have some new generic coder : MetadataDynamicCoder.
> MetadataDynamicCoder can decode/encode any new fields added to Metadata by
> sending getter, setter and coder.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
