[
https://issues.apache.org/jira/browse/BEAM-14243?focusedWorklogId=762981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762981
]
ASF GitHub Bot logged work on BEAM-14243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 15:34
Start Date: 27/Apr/22 15:34
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17479:
URL: https://github.com/apache/beam/pull/17479#discussion_r859938715
##########
.github/workflows/go_tests.yml:
##########
@@ -53,3 +53,7 @@ jobs:
run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD
|| (echo "Run go fmt before checking in changes" && exit 1)
- name: Run vet
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false
./... || (echo "Run go vet and fix warnings before checking in changes" && exit
1)
+ - uses: dominikh/[email protected]
+ with:
+ version: "2022.1.0"
+ install-go: false
Review Comment:
```suggestion
version: "2022.1.0"
install-go: false
```
The diff showed some weird spacing here (I think non-space/tab characters?),
that might keep actions from being able to parse this file (and is just better
to not have)
##########
.github/workflows/go_tests.yml:
##########
@@ -53,3 +53,7 @@ jobs:
run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD
|| (echo "Run go fmt before checking in changes" && exit 1)
- name: Run vet
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false
./... || (echo "Run go vet and fix warnings before checking in changes" && exit
1)
+ - uses: dominikh/[email protected]
Review Comment:
What is the advantage of using a 3rd party action over a script that calls
static check directly?
The reason I ask is that in general, I think we should prefer the latter if
there's not a reason we need an action. That makes it easier for users to tell
exactly what is being run/incorporate it into their own workflow, plus it
reduces our surface area for bugs/security issues. If there's a good reason to
use the action I'm 100% on board though
Issue Time Tracking
-------------------
Worklog Id: (was: 762981)
Time Spent: 1h (was: 50m)
> Add staticcheck to Go Github Actions precommits
> -----------------------------------------------
>
> Key: BEAM-14243
> URL: https://issues.apache.org/jira/browse/BEAM-14243
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add [staticcheck
> tool|https://staticcheck.io/docs/running-staticcheck/ci/github-actions/] to
> the Go SDK GitHub Actions suite to run as an additional precommit. Should
> only be done after the SDK's existing staticcheck warnings are addressed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
