[
https://issues.apache.org/jira/browse/BEAM-14243?focusedWorklogId=764349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764349
]
ASF GitHub Bot logged work on BEAM-14243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/22 16:43
Start Date: 29/Apr/22 16:43
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17479:
URL: https://github.com/apache/beam/pull/17479#discussion_r861974776
##########
.github/workflows/go_tests.yml:
##########
@@ -53,3 +53,7 @@ jobs:
run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD
|| (echo "Run go fmt before checking in changes" && exit 1)
- name: Run vet
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false
./... || (echo "Run go vet and fix warnings before checking in changes" && exit
1)
+ - uses: dominikh/[email protected]
Review Comment:
The staticcheck docs say 1.1, but it looks like 1.2 is the latest version.
We may as well be on the current version.
https://github.com/marketplace/actions/staticcheck
Issue Time Tracking
-------------------
Worklog Id: (was: 764349)
Time Spent: 2h 40m (was: 2.5h)
> Add staticcheck to Go Github Actions precommits
> -----------------------------------------------
>
> Key: BEAM-14243
> URL: https://issues.apache.org/jira/browse/BEAM-14243
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Add [staticcheck
> tool|https://staticcheck.io/docs/running-staticcheck/ci/github-actions/] to
> the Go SDK GitHub Actions suite to run as an additional precommit. Should
> only be done after the SDK's existing staticcheck warnings are addressed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
