[
https://issues.apache.org/jira/browse/BEAM-14243?focusedWorklogId=762989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762989
]
ASF GitHub Bot logged work on BEAM-14243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 15:38
Start Date: 27/Apr/22 15:38
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17479:
URL: https://github.com/apache/beam/pull/17479#discussion_r859952348
##########
.github/workflows/go_tests.yml:
##########
@@ -53,3 +53,7 @@ jobs:
run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD
|| (echo "Run go fmt before checking in changes" && exit 1)
- name: Run vet
run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false
./... || (echo "Run go vet and fix warnings before checking in changes" && exit
1)
+ - uses: dominikh/[email protected]
Review Comment:
The action is direct from the maintainers of staiccheck and is the
recommended way to include it in actions
(https://staticcheck.io/docs/running-staticcheck/ci/github-actions/).
Staticcheck isn't built-in to Go unlike fmt and vet so offloading the work of
downloading and configuring the tool to the third-party action seems reasonable
Issue Time Tracking
-------------------
Worklog Id: (was: 762989)
Time Spent: 1h 20m (was: 1h 10m)
> Add staticcheck to Go Github Actions precommits
> -----------------------------------------------
>
> Key: BEAM-14243
> URL: https://issues.apache.org/jira/browse/BEAM-14243
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Add [staticcheck
> tool|https://staticcheck.io/docs/running-staticcheck/ci/github-actions/] to
> the Go SDK GitHub Actions suite to run as an additional precommit. Should
> only be done after the SDK's existing staticcheck warnings are addressed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
